[Security] Fixing PHP example for limiting login attempts with rate limiter #19354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch @MirakuSan 👍 Can you please update the XML example as well (i.e. change line 1656 to |
|
yeap @xabbuh, I'll do this asap! 🙏 Edit: Done ✅ |
xabbuh
approved these changes
Dec 31, 2023
chalasr
approved these changes
Jan 1, 2024
javiereguiluz
force-pushed
the
fix/typo-php-example-limiting-login-attempts
branch
from
43b17c2 to
40227c9
Compare
|
Good catch Damien! Thanks and congrats on your first Symfony Docs contribution 🎉 |
|
Thanks @javiereguiluz but this is not my first contribution 😄 |
|
Sorry ... but GitHub displayed the "New contributor" label on your contribution 😐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After struggling with the rate limiter on my app.
I think the PHP example for « limiting login attempts » with a rate limiter has a bad copy/paste for the third option to pass to the container to register the
DefaultLoginRateLimiter::class.Using
new Reference('kernel.secret'), I had an error telling meNo services 'kernel.secret' foundHere is what I used and worked for me and so it is my proposal 🙏